Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group assignments #95

Merged
merged 64 commits into from
Sep 6, 2024
Merged

Group assignments #95

merged 64 commits into from
Sep 6, 2024

Conversation

EreminAnton
Copy link
Member

Merging development branch into the main, with new group assignments feature

EreminAnton and others added 30 commits August 26, 2024 16:04
@EreminAnton
feat: group access (dump work in progress)
1d49401
@EreminAnton
feat: allow prividing config by terraform
cf565ee
@EreminAnton
feat: add a way to approve requests
6237f4e
@EreminAnton
refactor: more handle errors func to the errors.py
c6f7351
@EreminAnton
refactoring: move sso to the sso.py & add more type hints
9084554
@EreminAnton
fix: import func from sso
990a20b
@EreminAnton
refactoring: use one "show initial form func, and move request handli…
d3928eb 
…ng to main.py
@EreminAnton
cleanup: rm unused
bbca552
@EreminAnton
feat: refactor build_approval_request_message_blocks to work with bot…
bd5d73d 
…h group's and account access
@EreminAnton
feat: use build_initial_form_handler to show initial form fo both typ…
b63aad1 
…es of requests
@EreminAnton
fix: import build_approval_request_message_blocks from slack_helpers …
46c999a 
…& rm unused
@EreminAnton
fmt: rm unused, refactor & more logs
ef93af1
@EreminAnton
fix: run codeguru only in main branch commits
09630ff
@EreminAnton
refactor: move schedule creation to the schedule.py
0822a7c
@EreminAnton
fmt: rm unused
eca56e2
@EreminAnton
feat: rename execute_decision to execute_decision_on_group_request
398c1e3
@EreminAnton
feat: handle if user is already in the group
7195354
@EreminAnton
feat: more refactorings & rename test.py to group.py
ca72333
@EreminAnton
feat: use default sesion
9f0af73
@EreminAnton
fix: NA if response is unbound
d86bf4f
@EreminAnton
fix: import RequestForGroupAccessView from slack_helpers
1dfb02c
@EreminAnton
fix: create response anyway, and use get to get value
8c37c37
@EreminAnton
feat: handle execute_decision_on_group_request logs better
fe0c32d
@EreminAnton
fix: pass correct event to the get_and_delete_scheduled_revoke_event_…
dd47c6b 
…if_already_exist
@EreminAnton
feat: add more logs to get_and_delete_scheduled_revoke_event_if_alrea…
9461be7 
…dy_exist
@EreminAnton
fix: provide membership_id in any case
394233c
@EreminAnton
fix: add group_revoke_event to the get_scheduled_events
07b6bab
@EreminAnton
feat: more logs for get_scheduled_events
0bdd62d
@EreminAnton
fix: get right type of events
6284261
@EreminAnton
fix: use right class in get_and_delete_scheduled_revoke_event_if_alre…
5e3598d 
…ady_exist
@EreminAnton EreminAnton added the enhancement New feature or request label Sep 5, 2024
@EreminAnton EreminAnton self-assigned this Sep 5, 2024
Andrey9kin
Andrey9kin reviewed Sep 5, 2024
View reviewed changes
src/schedule.py Outdated Show resolved Hide resolved
src/slack_helpers.py Outdated Show resolved Hide resolved
@EreminAnton
Copy link
Member Author

Merging branch to procced with testing, CI will be fixed later, in main branch

@EreminAnton EreminAnton merged commit 24a8b0a into main Sep 6, 2024
6 of 7 checks passed
@EreminAnton EreminAnton deleted the group-access branch September 6, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrey9kin Andrey9kin Andrey9kin left review comments

Assignees

@EreminAnton EreminAnton

Labels
enhancement New feature or request
Projects
Open source
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EreminAnton @Andrey9kin